Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

Add kit id and kit email to email about child participant #670

Merged
merged 3 commits into from Apr 22, 2014

Conversation

teravest
Copy link
Contributor

@teravest teravest commented Apr 7, 2014

3 things changed here.

The bullet point for "juvenile_age_less_than_7" now reads "Participant is older than 3 months and younger than 7 years of age" instead of "Participant is older than 3 months and younger than 13 years of age"

two new pieces of information are added to the email that gets sent to the help account.
kit_id and
kit email address

Previously only the ag_login_id was provided and I would have to look up the kit id for Elaine based on the ag_login_id

@ElDeveloper
Copy link
Member

This looks good 👍, should we test after we figure out what we want to do to test #607 ?

@teravest
Copy link
Contributor Author

can we get this one in on the deploy too? I completely forgot about this one, but it would make Elaine and Dana's lives a lot easier.

@ElDeveloper
Copy link
Member

Yes, I remember testing this and remembering everything was ok.

@ElDeveloper
Copy link
Member

@adamrp want to take a look?

@teravest
Copy link
Contributor Author

I'll toss it up on webdev

On Tue, Apr 22, 2014 at 1:53 PM, Yoshiki Vázquez Baeza <
notifications@github.com> wrote:

@adamrp https://github.com/adamrp want to take a look?


Reply to this email directly or view it on GitHubhttps://github.com//pull/670#issuecomment-41087442
.

@adamrp
Copy link
Member

adamrp commented Apr 22, 2014

Thanks, I remember this being fine, too -- please merge away!

On Tue, Apr 22, 2014 at 1:55 PM, teravest notifications@github.com wrote:

I'll toss it up on webdev

On Tue, Apr 22, 2014 at 1:53 PM, Yoshiki Vázquez Baeza <
notifications@github.com> wrote:

@adamrp https://github.com/adamrp want to take a look?


Reply to this email directly or view it on GitHub<
https://github.com/qiime/qiime_web_app/pull/670#issuecomment-41087442>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/670#issuecomment-41087655
.

ElDeveloper added a commit that referenced this pull request Apr 22, 2014
Add kit id and kit email to email about child participant
@ElDeveloper ElDeveloper merged commit 4de292d into qiime:master Apr 22, 2014
@ElDeveloper
Copy link
Member

Thanks @teravest

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants