Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port Bowtie2Index to q2-types #16

Merged
merged 3 commits into from
Jul 16, 2020
Merged

port Bowtie2Index to q2-types #16

merged 3 commits into from
Jul 16, 2020

Conversation

nbokulich
Copy link
Contributor

@nbokulich nbokulich commented Mar 26, 2020 •
edited

Just moving this to q2-types, nothing exciting to see here

DO NOT MERGE pending this PR: qiime2/q2-types#243

@nbokulich nbokulich added the stat:DO-NOT-MERGE Please do not merge this until this label has been removed. label Mar 26, 2020
@nbokulich nbokulich requested a review from ebolyen March 26, 2020 18:58
@nbokulich nbokulich removed the stat:DO-NOT-MERGE Please do not merge this until this label has been removed. label Mar 26, 2020
@nbokulich nbokulich requested review from thermokarst and removed request for ebolyen July 1, 2020 20:11
@nbokulich nbokulich assigned thermokarst and unassigned ebolyen Jul 1, 2020
@thermokarst thermokarst added this to In Review in 2020.8 via automation Jul 1, 2020
thermokarst
thermokarst suggested changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor tweak requested - inline. Otherwise, I tested these changes locally, all appears well in q2-shogun land.

q2_shogun/_shogun.py
@@ -17,7 +17,7 @@
from qiime2.util import duplicate
from q2_types.feature_data import DNAFASTAFormat

from q2_shogun._formats import Bowtie2IndexDirFmt
from q2_types.bowtie2 import Bowtie2IndexDirFmt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin recipe is missing an entry for q2_types (it also appears to be missing an entry for the framework, too).

@thermokarst thermokarst moved this from In Review to In Development in 2020.8 Jul 16, 2020
@thermokarst thermokarst assigned nbokulich and unassigned thermokarst Jul 16, 2020
@nbokulich
Copy link
Contributor Author

thanks @thermokarst ! Added those items to the recipe... 🏀

@nbokulich nbokulich assigned thermokarst and unassigned nbokulich Jul 16, 2020
@thermokarst thermokarst moved this from In Development to In Review in 2020.8 Jul 16, 2020
@coveralls
Copy link

coveralls commented Jul 16, 2020 •
edited

Pull Request Test Coverage Report for Build 35

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.04%) to 84.483%
Totals Coverage Status
Change from base Build 48: -6.04%
Covered Lines: 48
Relevant Lines: 54
💛 - Coveralls

@thermokarst thermokarst merged commit edccba8 into qiime2-graveyard:master Jul 16, 2020
2020.8 automation moved this from In Review to Changelog Needed Jul 16, 2020
@thermokarst thermokarst moved this from Changelog Needed to Completed in 2020.8 Aug 24, 2020
@gregcaporaso gregcaporaso removed this from Completed in 2020.8 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thermokarst thermokarst thermokarst approved these changes

Assignees

@thermokarst thermokarst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nbokulich @coveralls @thermokarst @ebolyen