Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bowtie2 index type/formats #243

Merged
merged 2 commits into from
Mar 26, 2020
Merged

bowtie2 index type/formats #243

merged 2 commits into from
Mar 26, 2020

Conversation

nbokulich
Copy link
Member

Just porting the bowtie2 index types over from q2-shogun so that we can use this in other plugins, e.g., q2-phylogenomics.

there were no tests in q2-shogun for this type, so let's open an issue after this PR is merged if this is needed.

Copy link
Member

@ebolyen ebolyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. More thoughts for future consideration: non-zipped artifacts (aka an artifact cache) would make this an even more useful format as we'd avoid unzipping gigabytes of data which will be re-used often.

@ebolyen ebolyen merged commit 004403d into qiime2:master Mar 26, 2020
@nbokulich
Copy link
Member Author

non-zipped artifacts (aka an artifact cache) would make this an even more useful format as we'd avoid unzipping gigabytes of data which will be re-used often.

shall I open an issue in q2-types for this? shall I also open an issue for adding tests for Bowtie2Index?

@ebolyen
Copy link
Member

ebolyen commented Mar 26, 2020

For the former, I think that's a framework-level problem. For the latter, I'm actually a little uncertain as to what we would test, maybe the shared prefix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants