ENH: Adds discard_untrimmed to trim methods
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thermokarst
changed the title
discard_untrimmed to filter methodsdiscard_untrimmed to trim methods
nbokulich
requested changes
Mar 27, 2019
There was a problem hiding this comment.
Looks good @thermokarst . I pulled down and tire kicking was a success.
Looks like the parameter descriptions need a little tweak, see per-line comments. Otherwise this is ready to go.
Also: it looks like this method can output empty artifacts. Something to consider if you want to output trimmed and untrimmed together now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
This still needs a tire-kicking. ☸️