ENH: Add read length seven-number summary #84
Conversation
There was a problem hiding this comment.
Thanks @jakereps! A few minor requests inline. This looks great, and certainly helps with the 'pre-joined' issue described here: https://docs.qiime2.org/2018.4/tutorials/read-joining/#viewing-a-summary-of-joined-data-with-read-quality
| @@ -95,6 +95,17 @@ def _compute_stats_of_df(df): | |||
| return df_stats | |||
|
|
|||
|
|
|||
| def _build_seq_len_table(qscores: pd.DataFrame) -> str: | |||
There was a problem hiding this comment.
Can we make these counts integers?
Maybe we could also tack on some units, too?
| <div class="row"> | ||
| <div class="col-lg-12"> | ||
| <h1>Per-sample sequence counts</h1> | ||
| <h4>Total Samples: {{ n_samples }}</h4> |
There was a problem hiding this comment.
Can we also add the total reads (before subsampling)?
There was a problem hiding this comment.
Would this be relocating or in addition to the first table's Total row?
There was a problem hiding this comment.
I am not a smart man. I think I got confused while reviewing - please disregard!
| @@ -25,9 +25,28 @@ <h1>Demultiplexed sequence counts summary</h1> | |||
| </div> | |||
| {% endif %} | |||
|
|
|||
| <div class="row"> | |||
There was a problem hiding this comment.
Can this table get moved into the Quality Plots tab? You can probably get away with just sticking this in as a new row near the bottom of the page (maybe?)
|
Thanks, @thermokarst 👍 Just one clarifying question. |
|
Thanks @jakereps! This looks great! |
|
TIL Service Workers are live on iOS Safari! That link fully worked on mobile. 📱🏆 |
Fixes #71
Wasn't sure where to place the results, so I ended up just putting it on the main overview page.
Previews:
TODO: