REF: group-timepoints to create Dist1D[nestedOrdered]

[cherman2]

No description provided.

[cherman2]

Linked to qiime2/q2-stats#21

[cherman2]

Validator for Dist1D[Nested] here: qiime2/q2-stats#22

[cherman2]

Thanks @lizgehret for taking a look at this. Let me know if you need any clarification!

[lizgehret]

overall this lgtm @cherman2, just a couple of stray print statements that could be removed!

[cherman2]

Thanks @lizgehret,
Those suggestions have been addressed! I also edited a comment that mentioned GroupDists (commit dd4d19d)

[lizgehret]

Whoah, not sure what happened to CI here - setup & lint shouldn't be running twice. @cherman2 can you try pushing up another commit (maybe just fixing the lint error) to see if this was just a stochastic issue?

[cherman2]

Seems like that fixed it @lizgehret

[lizgehret]

Hmm, this is interesting - your TypeMap looks identical to your T_subject, T_dependence one (which seems like it mirrors the use-case for this one). Were you getting these failures locally as well?

[cherman2]

I don't remember getting these failures when I marked the PR ready for review but I am getting them locally. Seems like the subject map is doing a check that I am not doing. I think the check is on line 230 of _engraftment.py

edit: yup that was it

[cherman2]

New error and explanation... I apparently didn't hook up group to engraftment pipeline, so when we pass group into grouptimes in the pipeline it errors. I will fix this but It might take me a minute since this isn't as minor of an edit and im OOO.

[lizgehret]

New error and explanation... I apparently didn't hook up group to engraftment pipeline, so when we pass group into grouptimes in the pipeline it errors. I will fix this but It might take me a minute since this isn't as minor of an edit and im OOO.

Gotcha, that makes sense - just ping me when you're ready for another round of review!

[cherman2]

Alright, I remembered why engraftment didn't get hooked up. I don't have the stats I need to use the pipeline effectively yet. So for now I think Dist1D[nestedOrdered] should only be possible outside of the engraftment pipeline. Once I have those stats I will hook up engraftment pipeline to make Dist1D[nestedOrdered]. Issue #80