Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iqtree associated actions to be deprecated in q2-phylogeny #72

Merged
merged 22 commits into from
Nov 19, 2020

Conversation

mikerobeson
Copy link
Member

Existing IQ-TREE 2 functionality is in the process of being transferred from q2-phylogeny to q2-iqtree2.

This PR simply sets deprecated=True to the following actions within q2-phylogeny:

  • iqtree
  • iqtree-ultrafast-bootstrap
  • align-to-tree-mafft-iqtree

@thermokarst
Copy link
Contributor

Hi @mikerobeson! Sorry for the slow response here - looks like something might've gone wrong with the branch here, the "Files changed" tab is empty... Let me know if you want a hand poking around at things, happy to help!

@thermokarst thermokarst moved this from In Review to In Development in 2020.11 Nov 16, 2020
@mikerobeson
Copy link
Member Author

Weird! Not sure what happened. I'll try and fix it.

@mikerobeson
Copy link
Member Author

@thermokarst, looks like I got it working. Should only be the 1 file q2_phylogeny/plugin_setup.py.

@mikerobeson mikerobeson removed their assignment Nov 17, 2020
@thermokarst thermokarst moved this from In Development to In Review in 2020.11 Nov 19, 2020
@thermokarst thermokarst self-assigned this Nov 19, 2020
@thermokarst thermokarst self-requested a review November 19, 2020 17:44
Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikerobeson!

@thermokarst thermokarst merged commit 70c145a into qiime2:master Nov 19, 2020
2020.11 automation moved this from In Review to Changelog Needed Nov 19, 2020
@mikerobeson mikerobeson deleted the deprecate-iqtree branch November 19, 2020 20:48
@andrewsanchez andrewsanchez moved this from Changelog Needed to Completed in 2020.11 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2020.11
Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants