Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: adds JoinedSequencesWithQuality #160

Merged
merged 1 commit into from
Nov 16, 2017
Merged

ENH: adds JoinedSequencesWithQuality #160

merged 1 commit into from
Nov 16, 2017

Conversation

gregcaporaso
Copy link
Member

@gregcaporaso gregcaporaso commented Nov 16, 2017

It's been a while since I've added a new type - let me know if I'm missing anything here.

@gregcaporaso gregcaporaso changed the title ENH: adds MergedSequencesWithQuality ENH: adds JoinedSequencesWithQuality Nov 16, 2017
@jairideout
Copy link
Member

Gave it a quick look, I think you got all the pieces! Does your plugin need any transformers defined or does it just need the directory format itself?

@gregcaporaso
Copy link
Member Author

Thanks @jairideout - no new transformers are needed for this.

Copy link
Member

@jairideout jairideout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MVP @gregcaporaso MVP

@jairideout jairideout merged commit cb25ec1 into qiime2:master Nov 16, 2017
@gregcaporaso gregcaporaso deleted the merged-seqs-with-qual branch November 16, 2017 23:56
@gregcaporaso
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants