BUG: Taxa formats whitespace and comments #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or ' #' in tsv files.
thermokarst
changed the title
thermokarst
changed the title
thermokarst
suggested changes
Jul 26, 2019
thermokarst
suggested changes
Aug 6, 2019
thermokarst
suggested changes
Aug 6, 2019
There was a problem hiding this comment.
Also, you will need to update _format.py to remove the comment-line checks in the sniffer.
thermokarst
suggested changes
Aug 6, 2019
thermokarst
suggested changes
Aug 7, 2019
q2_types/feature_data/tests/data/taxonomy/start_end_space_taxon.tsv
Outdated
Show resolved
Hide resolved
thermokarst
approved these changes
Aug 8, 2019
This was referenced Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for items that follow a '#' or ' #' in tsv files to remain in the file, instead of being seen as a comment. This PR is related to issue #179.
Issue #174 also pertains to a white space issue regarding ID's and taxonomic data that follows a space. This may be relevant to this PR, which would result in further commits.