TST: Updating and fixing tests #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thermokarst
commented
Nov 12, 2019
| @@ -198,7 +206,7 @@ def test_miseq_demux_dirfmt_to_slpspefdf(self): | |||
| def test_fastqmanifest_single(self): | |||
| _, dirfmt = self.transform_format( | |||
| CasavaOneEightSingleLanePerSampleDirFmt, | |||
| SingleLanePerSamplePairedEndFastqDirFmt, | |||
| SingleLanePerSampleSingleEndFastqDirFmt, | |||
There was a problem hiding this comment.
Note, this appears to be the only "real" error in this test suite, so if we decide to close this PR let's add a TODO/issue to fix this little typo.
|
Yikes, let's try and figure this one out in person. I agree that importing |
ebolyen
added
the
stat:blocking-other
|
Before closing this PR I want to open a replacement with the minor bugfix (identified inline, above). I will also open a PR on the framework with some comments to explain things a bit more (this comment here is a bit out of context, but will be remedied later!). |
|
Uh oh, I think I forgot what I was referring to above... |
Merged
|
Superseded by qiime2/qiime2#527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preemptively addressing fallout from qiime2/qiime2#494.
Pre- qiime2/qiime2#494,
TestPlugin.transform_format&TestPlugin.get_transformereschewed the SDK's transformer lookup machinery as a way to conveniently lookup transformers without exposing the less-than-illustrative function names (who wants to import a function named_15, anyway?). qiime2/qiime2#494 drops that ability, by makingTestPlugin.get_transformergo "all-in" on the transformation API, validations and all. Possible paths forward:Thoughts @ebolyen?