Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Improve error message for invalid characters in DNAFASTAFormat #238

Merged
merged 2 commits into from
Feb 14, 2020
Merged

MAINT: Improve error message for invalid characters in DNAFASTAFormat #238

merged 2 commits into from
Feb 14, 2020

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Jan 24, 2020

Implements the improvements discussed at the end of #214. Namely we now display to the user the first invalid character on the first invalid line.

@Oddant1
Copy link
Member Author

Oddant1 commented Jan 24, 2020

Only failure is headers

@Oddant1 Oddant1 added this to In Review in 2020.2 Jan 24, 2020
@thermokarst thermokarst assigned ebolyen and unassigned thermokarst Jan 24, 2020
@ebolyen ebolyen merged commit af4f114 into qiime2:master Feb 14, 2020
2020.2 automation moved this from In Review to Changelog Needed Feb 14, 2020
@Oddant1 Oddant1 moved this from Changelog Needed to Completed in 2020.2 Feb 19, 2020
@Oddant1 Oddant1 deleted the improve-FASTA-validate branch June 25, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebolyen ebolyen ebolyen approved these changes

Assignees

@ebolyen ebolyen

Labels
None yet
Projects
No open projects
2020.2
  
Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Oddant1 @ebolyen @thermokarst