Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPluginBase.transform_format does not validate it output #492

Closed
Oddant1 opened this issue Sep 9, 2019 · 0 comments · Fixed by #527
Closed

TestPluginBase.transform_format does not validate it output #492

Oddant1 opened this issue Sep 9, 2019 · 0 comments · Fixed by #527

Comments

@Oddant1
Copy link
Member

Oddant1 commented Sep 9, 2019

Improvement Description
Validate the output of TestPluginBase.transform_format

Current Behavior
The standard transformation API ensures the validity of the formats output by the transformer., but TestPluginBase.transform_format skips the API and calls the transfomer directly allowing for transformers tested in this manner to potentially produce invalid outputs.

Proposed Behavior
Ensure outputs of transformers called via TestPluginBase.transform_format are valid

References

  1. This was first noticed by @ebolyen in the issue IMP: Add transformer from slpssefdf to Casava q2-types#226
@ebolyen ebolyen transferred this issue from qiime2/q2-demux Sep 9, 2019
@ebolyen ebolyen added the Hacktoberfest Good fit for the Hacktoberfest challenge label Oct 9, 2019
@ebolyen ebolyen removed the Hacktoberfest Good fit for the Hacktoberfest challenge label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants