IMP: Add transformer from slpssefdf to Casava #226
Conversation
|
The transformer in 3f357bc now copies all non MANIFEST/metadata files to a temp directory and creates the casavadirfmt from that, I did this because I didn't think we wanted to just kill off the MANIFEST and metadata files, but I can just kill them and use the directory that was passed in to the transformer if we don't care about them anymore. |
| @@ -351,7 +360,7 @@ def _9(fmt: PairedEndFastqManifestPhred64) \ | |||
|
|
|||
|
|
|||
| @plugin.register_transformer | |||
| def _12(dirfmt: SingleLanePerSampleSingleEndFastqDirFmt) \ | |||
| def _27(dirfmt: SingleLanePerSampleSingleEndFastqDirFmt) \ | |||
There was a problem hiding this comment.
DBC: Why not keep this as _12, and name the new one _27? Just so you know, with transformers the names of the functions don't matter, we just took the strategy of naming them _number, but it can be anything
There was a problem hiding this comment.
Honestly, probably just because I saw _10, _11 and was bothered at the idea of the next thing being _27 but I guess the rest isn't in numerical order anyway 😆
|
Hey there @ChrisKeefe, can you please review this PR when you get a chance? Please address any changes you might want made to @ebolyen & I - we are teaming up to run this one across the finish line! |
|
This isn't a high priority, and there's a few issues, so we'll just close this for now, so that everyone can focus on other things. |
|
@ebolyen can we reopen this PR and finish up this issue? |
Oddant1
changed the title
|
I think this is still pretty low priority, I'm tempted to move it off the backlog, but it would be nice to have in the future. Let's hold off for now. |
Closes #209