Compatibility with 32-bits CPU architectures #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 64-bits CPUs, the pandas.dtype returned for integers is a plain 'int' 64 bits wide. On 32-bits machines however, the type is returned as 'int64' to differenciate from plain 'int', which is 32 bits wide in such context. When running the test suite on 32-bits CPU architectures, the error output includes several instances of the following: ====================================================================== ERROR: test_artifacts_mismatch (qiime2.metadata.tests.test_metadata_column.TestEqualityOperators) ---------------------------------------------------------------------- Traceback (most recent call last): File "/tmp/autopkgtest-lxc.shmdvuw3/downtmp/autopkgtest_tmp/qiime2/metadata/tests/test_metadata_column.py", line 344, in test_artifacts_mismatch mdc1 = DummyMetadataColumn(series) File "/tmp/autopkgtest-lxc.shmdvuw3/downtmp/autopkgtest_tmp/qiime2/metadata/metadata.py", line 875, in __init__ raise TypeError( TypeError: DummyMetadataColumn 'col1' does not support a pandas.Series object with dtype int64 This commit ought to enable the 'int64' type for the class of the test suite DummyMetadataColumn.
On 64-bits CPUs, the pandas.dtype returned for integers is a plain 'int' 64 bits wide. On 32-bits machines however, the type is returned as 'int64' to differenciate from plain 'int', which is 32 bits wide in such context. When running the test suite on 32-bits CPU architectures, the error output includes several instances similar to: ====================================================================== ERROR: test_decode_numeric_value (qiime2.core.type.tests.test_primitive.TestMetadataColumn) ---------------------------------------------------------------------- Traceback (most recent call last): File "/tmp/autopkgtest-lxc.shmdvuw3/downtmp/autopkgtest_tmp/qiime2/core/type/tests/test_primitive.py", line 66, in test_decode_numeric_value num_md = metadata.NumericMetadataColumn(value) File "/tmp/autopkgtest-lxc.shmdvuw3/downtmp/autopkgtest_tmp/qiime2/metadata/metadata.py", line 875, in __init__ raise TypeError( TypeError: NumericMetadataColumn 'foo' does not support a pandas.Series object with dtype int64 This commit ought to enable the 'int64' type for the class NumericMetadataColumn.
|
@ebolyen any reason we should hold off merging this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
While working on issue #520 related to migration to python 3.9 in the Debian project, I caught an issue specific to 32-bits CPU architectures. On 64-bits CPUs, the pandas.dtype returned for integers is a plain int 64 bits wide. However, on 32 bits machines, the type is returned as int64 to differenciate from plain int, which I suppose would be 32 bits wide in such context.
Due to this, when running the test suite on 32-bits CPU architectures, the error output includes several instances of errors such as the following:
Please note I did not know whether 32 bits support was under your radar or not, so in doubt I just leave that merge request for your convenience. I understand these limited architectures are usually a concern in bioinformatics, but I also heard of cases where architectures like armhf (which is 32 bits) were in use in various educational contexts.
Have a nice day, :)
Étienne.