Skip to content

Commit

Permalink
fixing @ElDeveloper suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
squirrelo committed Jul 15, 2014
1 parent ce60f29 commit f8147d8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion qiita_db/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ def data_type(self, ret_id=False):
Returns
-------
str or int
string value of data_type or data_type_id
string value of data_type or int if data_type_id
"""
ret = "_id" if ret_id else ""
conn_handler = SQLConnectionHandler()
Expand Down
6 changes: 1 addition & 5 deletions qiita_db/test/test_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,6 @@ def test_create(self):
obs = self.conn_handler.execute_fetchall(
"SELECT * FROM qiita.preprocessed_data WHERE "
"preprocessed_data_id=3")
# preprocessed_data_id, raw_data_id, preprocessed_params_tables,
# preprocessed_params_id
exp = [[3, "preprocessed_sequence_illumina_params", 1, False, 2]]
self.assertEqual(obs, exp)

Expand Down Expand Up @@ -194,7 +192,7 @@ def test_create(self):
self.assertEqual(obs, exp)

def test_create_data_type_only(self):
# Check that the returned object has the correct id
# Check that the returned object has the correct id
obs = PreprocessedData.create(self.study, self.params_table,
self.params_id, self.filepaths,
data_type="18S")
Expand All @@ -204,8 +202,6 @@ def test_create_data_type_only(self):
obs = self.conn_handler.execute_fetchall(
"SELECT * FROM qiita.preprocessed_data WHERE "
"preprocessed_data_id=3")
# preprocessed_data_id, raw_data_id, preprocessed_params_tables,
# preprocessed_params_id
exp = [[3, "preprocessed_sequence_illumina_params", 1, False, 2]]
self.assertEqual(obs, exp)

Expand Down

0 comments on commit f8147d8

Please sign in to comment.