Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we change the expected time stamp format? #1885

Closed
ackermag opened this issue Jul 7, 2016 · 14 comments
Closed

Can we change the expected time stamp format? #1885

ackermag opened this issue Jul 7, 2016 · 14 comments
Milestone

Comments

@ackermag
Copy link

ackermag commented Jul 7, 2016

Currently these are required for validation:
mm/dd/yyyy hh:mm:ss or mm/dd/yyyy hh:mm or mm/dd/yyyy hh or mm/dd/yyyy or mm/yyyy or yyyy.

None of these are compatible with Excel, requiring individual curation. Please...or should I just ignore the warnings ( in the template the year is yyyy but it is shortened).
804_20160706-235613.txt

@antgonza
Copy link
Member

antgonza commented Jul 7, 2016

Looking at the defaults in Excel, see below, I can add:
mm/dd/yy hh:mm:ss
mm/dd/yy hh:mm
mm/dd/yy hh
mm/dd/yy
mm/yy
m/dd/yy hh:mm:ss
m/dd/yy hh:mm
m/dd/yy hh
m/dd/yy
m/yy

Sounds good?

screen shot 2016-07-07 at 8 49 20 am

@antgonza
Copy link
Member

antgonza commented Jul 8, 2016

friendly ping to @ackermag

@antgonza antgonza modified the milestone: Sloan workshop 2016 Jul 10, 2016
@ackermag
Copy link
Author

Sounds good... to me.

@antgonza
Copy link
Member

Still need to fix it! Will issue PR soon. :)

@ackermag
Copy link
Author

From MIMARKS_v4.xls
"The time of sampling, either as an instance (single point in time) or interval. In case no exact time is available, the date/time can be right truncated i.e. all of these are valid times: 2008-01-23T19:23:10+00:00; 2008-01-23T19:23:10; 2008-01-23; 2008-01; 2008; Except: 2008-01; 2008 all are ISO8601 compliant"
Although most of our users (I believe) are US based and conform to mm/dd/yyyy where Excel trims to ((m)m/(d)d-yy), confusion arises with non-US users. (As a general rule, users rarely conform to a suggested format.) I am open to suggestion again, but suggest we use the recommendation but not require '2008-01-23T19:23:10+00:00' or '2008-01-23T19:23:10' because no-one will conform to that.

Suggest:
YYYY-MM-DD HH:MM; YYYY-MM-DD; YYYY-MM, YYYY all acceptable. (With - or / between numbers.)
MIMARKS_v4.xls.zip

@wasade
Copy link
Contributor

wasade commented Jan 27, 2017 via email

@josenavas
Copy link
Contributor

Agree on sticking to a standard. Is a bit frustrating, however, that this was not brought up when it was discussed 8 months ago. There are a fair amount of studies in the DB that will be affected by these and will need to be fixed.

@antgonza
Copy link
Member

@wasade and @ackermag, a couple of questions

  1. We currently accept the below values, should we simply add the options with - or remove the / and only accept -?
# 4 digits year
'%m/%d/%Y %H:%M:%S', '%m/%d/%Y %H:%M',
'%m/%d/%Y %H', '%m/%d/%Y', '%m/%Y', '%Y',
# 2 digits year
'%m/%d/%y %H:%M:%S', '%m/%d/%y %H:%M',
'%m/%d/%y %H', '%m/%d/%y', '%m/%y', '%y'
  1. If we change to only accept -, should we review all current values in the DB and replace dates from / to -?

@wasade
Copy link
Contributor

wasade commented Jan 28, 2017 via email

@antgonza
Copy link
Member

OK, so that means only -, right? What about question 2?

@ackermag
Copy link
Author

ackermag commented Jan 28, 2017 via email

@rob-knight
Copy link

rob-knight commented Jan 28, 2017 via email

@ackermag
Copy link
Author

ackermag commented Jan 28, 2017 via email

@antgonza
Copy link
Member

antgonza commented Apr 5, 2017

Closed by #2075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants