Simplify rest api #1853
Merged
Simplify rest api #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Returns | ||
| ------- | ||
| dict | ||
| {'filepaths': list of (str, str)} | ||
| The filepaths attached to the artifact and their filepath types | ||
| {''} |
|
One minor comment. @ElDeveloper or @squirrelo could you check this PR? |
| if artifact_type not in FILEPATH_TYPE_TO_NOT_SHOW_HEAD: | ||
| # we need to encapsulate the full for loop because gzip will | ||
| # not raise an error until you try to read | ||
| try: |
There was a problem hiding this comment.
Instead of doing a try/except you could read in the magic number right? It would probably amount to the same lines of code in total, but at least there wouldn't be an except IOError (which can also be raised if the file doesn't exist IIRC).
There was a problem hiding this comment.
Just noticed this was not code you really changed ... so yeah feel free to disregard that.
|
Looks good. |
|
The commits will not change the passing status, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for simplifying the REST api.
The current REST api for the artifacts was getting complex with a lot of endpoints. Right now, it has been reduced to a single endpoint to get all the information.
I've started modifying some of the plugins but not all of them. Doing the PR against a different branch given our last discussion in the Qiita meeting so we can get some discussion started about the API.