Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes #3341

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Conversation

antgonza
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Dec 18, 2023

Coverage Status

coverage: 92.906% (-0.001%) from 92.907%
when pulling 74d282f on antgonza:fix-after-review.12.2023
into 30eb772 on qiita-spots:dev.

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm a few things.

CHANGELOG.md Outdated

* The sample and preparation information pages will display the timestamp of their last update.
* Added a ProcessingJob.complete_processing_job method to retrieve the job that is completing the current job.
* Added a ProcessingJob.complete_processing_job method to retrieve the job that is completing the current job.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks like a duplicate of the one above.

qiita_db/metadata_template/prep_template.py Show resolved Hide resolved
Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@charles-cowart charles-cowart merged commit 02dc7a0 into qiita-spots:dev Dec 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants