-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Maintenance PR #1210
Windows Maintenance PR #1210
Conversation
@@ -0,0 +1,244 @@ | |||
from __future__ import annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to rename struct
to some other names? It shadows the standard library struct
and might cause some confusion for our users. (ql.os
name clash had already caused a few confusion before)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't come up with any reasonable alternative really.. any suggestions?
Do not merge yet; a few commits to follow. |
Good to go ? |
This PR aggregates additional commits on top of older ones that were not merged, so it became a bit messy..
Highlights:
New struct module
A generic
ctypes
structure base class that provides intuitive accessors for easier data handling, simplifying data coherency (consistency with memory). The newBaseStruct
class inherits allctypes.Structure
methods and properties, and provides additional ones on top of them.Following are a few examples to show off the new capabilities: