Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving workflow for dual frame optimization #21

Merged
merged 32 commits into from
Jun 12, 2024
Merged

Improving workflow for dual frame optimization #21

merged 32 commits into from
Jun 12, 2024

Conversation

timmintam
Copy link
Collaborator

The goal of this PR is to improve:

  1. the interface for the optimization of dual frames
  2. performance of the optimization process
  3. performance of the computation of the decomposition weights
  4. memory usage of dual frames

@timmintam timmintam mentioned this pull request May 30, 2024
Merged
@timmintam timmintam linked an issue Jun 4, 2024 that may be closed by this pull request
[API] de-duplicate the get_expectation_value and get_single_exp_value_and_std methods #24
Closed
@timmintam timmintam marked this pull request as ready for review June 10, 2024 07:27
@timmintam timmintam requested a review from mrossinek June 10, 2024 07:27
mrossinek
mrossinek reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to review the three new PPPs but submitting this review as is for now 👍

docs/how_tos/dual_optimizer.ipynb Outdated Show resolved Hide resolved
docs/tutorials/getting_started.ipynb Outdated Show resolved Hide resolved
docs/tutorials/parametrized_circuit.ipynb Outdated Show resolved Hide resolved
povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/ppp_empirical_frequencies.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/base_dual.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/product_dual.py Show resolved Hide resolved
test/library/test_randomized_projective_measurements.py Outdated Show resolved Hide resolved
mrossinek
mrossinek reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments after my earlier review

test/sampler/test_povm_sampler_job.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/state_optimal.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/state_marginal.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/empirical_frequencies.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/empirical_frequencies.py Outdated Show resolved Hide resolved
mrossinek
mrossinek reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments and modulo the unittests this is good to go 👍

docs/how_tos/dual_optimizer.ipynb Outdated Show resolved Hide resolved
docs/how_tos/dual_optimizer.ipynb Outdated Show resolved Hide resolved
docs/how_tos/dual_optimizer.ipynb Outdated Show resolved Hide resolved
docs/how_tos/dual_optimizer.ipynb Outdated Show resolved Hide resolved
povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/dual_from_marginal_probabilities.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/dual_from_marginal_probabilities.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/dual_from_empirical_frequencies.py Show resolved Hide resolved
povm_toolbox/post_processor/dual_from_empirical_frequencies.py Show resolved Hide resolved
povm_toolbox/post_processor/dual_from_empirical_frequencies.py Outdated Show resolved Hide resolved
@timmintam timmintam requested a review from mrossinek June 11, 2024 15:54
mrossinek
mrossinek reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done! Some minor feedback on the unittests and one naming discussion

povm_toolbox/post_processor/dual_from_state.py Outdated Show resolved Hide resolved
test/post_processor/test_dual_from_state.py Outdated Show resolved Hide resolved
test/post_processor/test_dual_from_state.py Outdated Show resolved Hide resolved
test/post_processor/test_dual_from_state.py Outdated Show resolved Hide resolved
test/post_processor/test_dual_from_marginal_probabilities.py Outdated Show resolved Hide resolved
test/post_processor/test_dual_from_state.py Outdated Show resolved Hide resolved
test/post_processor/test_dual_from_empirical_frequencies.py Outdated Show resolved Hide resolved
docs/how_tos/dual_optimizer.ipynb Outdated Show resolved Hide resolved
mrossinek
mrossinek approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍

@mrossinek mrossinek merged commit e89be6c into main Jun 12, 2024
8 checks passed
@mrossinek mrossinek deleted the optimize_dual branch June 12, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrossinek mrossinek mrossinek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API] de-duplicate the get_expectation_value and get_single_exp_value_and_std methods
2 participants
@timmintam @mrossinek