-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix power() in subclass test for QuantumCircuit change #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, I see in the nightlies that mypy has been failing too recently. I'll see about fixing that in this PR too. At cursory glance it started with the latest mypy release.
|
Pull Request Test Coverage Report for Build 8943306519Details
💛 - Coveralls |
Merged
ElePT
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Steve
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2024
(cherry picked from commit 0bdd2dc)
This was referenced May 6, 2024
mergify bot
added a commit
that referenced
this pull request
May 6, 2024
#174) Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
BrunoRosendo
pushed a commit
to BrunoRosendo/qiskit-algorithms
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Qiskit tests against main have been failing lint recently due to power() in QuantumCircuit gaining an extra parameter. With 1.1 going live shortly, where it will become the stable version tested against here, this amends the test to work and pass lint for existing versions of Qiskit e.g 0.46 and 1.0 as well as 1.1
Details and comments
As it's just a test case fix there is no reno needed. I marked this for backporting to stable as it will affect any builds done there once 1.1 releases.