Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix power() in subclass test for QuantumCircuit change #172

Merged
merged 3 commits into from
May 6, 2024

Conversation

woodsp-ibm
Copy link
Member

Summary

Qiskit tests against main have been failing lint recently due to power() in QuantumCircuit gaining an extra parameter. With 1.1 going live shortly, where it will become the stable version tested against here, this amends the test to work and pass lint for existing versions of Qiskit e.g 0.46 and 1.0 as well as 1.1

Details and comments

As it's just a test case fix there is no reno needed. I marked this for backporting to stable as it will affect any builds done there once 1.1 releases.

@woodsp-ibm woodsp-ibm added the stable backport potential The bug might be minimal and/or import enough to be port to stable label May 3, 2024
@woodsp-ibm woodsp-ibm assigned ElePT and unassigned ElePT May 3, 2024
@woodsp-ibm
Copy link
Member Author

woodsp-ibm commented May 3, 2024

Oh, I see in the nightlies that mypy has been failing too recently. I'll see about fixing that in this PR too. At cursory glance it started with the latest mypy release.

qiskit_algorithms/gradients/reverse/derive_circuit.py: note: In function "derive_circuit":
qiskit_algorithms/gradients/reverse/derive_circuit.py:153: error: Incompatible types in assignment (expression has type "complex", variable has type "int")  [assignment]
Found 1 error in 1 file (checked 218 source files)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8943306519

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.612%

Totals Coverage Status
Change from base Build 8804383908: 0.0%
Covered Lines: 6496
Relevant Lines: 7169

💛 - Coveralls

@woodsp-ibm woodsp-ibm mentioned this pull request May 3, 2024
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Steve

@ElePT ElePT merged commit 0bdd2dc into qiskit-community:main May 6, 2024
19 checks passed
mergify bot pushed a commit that referenced this pull request May 6, 2024
mergify bot added a commit that referenced this pull request May 6, 2024
#174)

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
@woodsp-ibm woodsp-ibm deleted the fix_1.1_lint branch May 6, 2024 12:44
BrunoRosendo pushed a commit to BrunoRosendo/qiskit-algorithms that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants