Upgrade to qiskit_sphinx_theme 1.12 #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
stefan-woerner,
woodsp-ibm and
t-imamichi
as code owners
|
I think CI might have broken on main? These test failures don't look related to my changes. |
|
I'll investigate and sort it out - I notice the scheduled builds have been failing daily for the past 5 days. Done: #274 |
Eric-Arellano
commented
May 23, 2023
| @@ -61,7 +61,8 @@ commands = | |||
| sphinx-build -W -T --keep-going -b gettext docs/ docs/_build/gettext {posargs} | |||
| sphinx-intl -c docs/conf.py update -p docs/_build/gettext -l en -d docs/locale | |||
|
|
|||
| [pycodestyle] | |||
Pull Request Test Coverage Report for Build 5071613254
💛 - Coveralls |
woodsp-ibm
added
stable backport potential
woodsp-ibm
approved these changes
May 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2023
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> (cherry picked from commit 25a6546)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.12 theme release is focused on stability, including CSS fixes. See https://github.com/Qiskit/qiskit_sphinx_theme/releases/tag/1.12.0rc1 for the changelog.
It allows us to de-duplicate custom_directives.py, versionutils.py, and _static/no_image.png.
This PR also:
pyproject.tomlentry for how to build this distribution. It is highly recommended that all Python projects have this.-j autowith Sphinx to have parallelism. This should result in a faster docs build.tox -e docs-clean, which is useful because Sphinx's autodoc sometimes has bad cache state.