Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QubitConverter deprecation #1073

Merged
merged 9 commits into from
Feb 27, 2023

Conversation

mrossinek
Copy link
Member

Summary

This PR resolves the remaining open points revolving around #967.

Details and comments

I am already opening this now but I plan to tackle the renaming of qubit_converter -> qubit_mapper in this PR, too.

@mrossinek mrossinek added this to the 0.6.0 milestone Feb 22, 2023
This was linked to issues Feb 22, 2023
@mrossinek mrossinek self-assigned this Feb 22, 2023
@mrossinek mrossinek force-pushed the qubit-converter-deprecation branch 2 times, most recently from 224d9a1 to e345fd7 Compare February 23, 2023 10:11
@mrossinek mrossinek marked this pull request as ready for review February 23, 2023 10:11
@coveralls
Copy link

coveralls commented Feb 24, 2023

Pull Request Test Coverage Report for Build 4284972494

  • 243 of 286 (84.97%) changed or added relevant lines in 27 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 85.947%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_nature/second_q/algorithms/excited_states_solvers/qeom.py 32 33 96.97%
qiskit_nature/second_q/algorithms/ground_state_solvers/ground_state_solver.py 7 8 87.5%
qiskit_nature/second_q/circuit/library/ansatzes/succd.py 4 5 80.0%
qiskit_nature/second_q/problems/base_problem.py 8 9 88.89%
qiskit_nature/second_q/circuit/library/ansatzes/ucc.py 22 24 91.67%
qiskit_nature/second_q/algorithms/excited_states_solvers/excited_states_eigensolver.py 8 11 72.73%
qiskit_nature/second_q/algorithms/ground_state_solvers/ground_state_eigensolver.py 9 12 75.0%
qiskit_nature/second_q/circuit/library/ansatzes/uvcc.py 30 33 90.91%
qiskit_nature/second_q/circuit/library/initial_states/hartree_fock.py 25 28 89.29%
qiskit_nature/second_q/problems/electronic_structure_problem.py 10 13 76.92%
Totals Coverage Status
Change from base Build 4284307085: 0.006%
Covered Lines: 18146
Relevant Lines: 21113

💛 - Coveralls

@mrossinek mrossinek linked an issue Feb 26, 2023 that may be closed by this pull request
@mrossinek mrossinek force-pushed the qubit-converter-deprecation branch 2 times, most recently from 8e56645 to 7c4e2de Compare February 26, 2023 16:18
@mergify mergify bot merged commit 53a3e98 into qiskit-community:main Feb 27, 2023
@mrossinek mrossinek deleted the qubit-converter-deprecation branch March 1, 2023 07:37
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
* Deprecate the QubitConverter class

* Some deprecations around the TaperedQubitMapper workflow

* Implement the _ListOrDict.wrap utility

* fix: do not drop deprecated arguments which have no replacement

* Deprecate all public QubitConverter naming in favor of QubitMapper

* Add release note

* Fix edge cases around settings.use_pauli_sum_op

Closes qiskit-community#1076

* Add HF bitstring test for ParityMapper with builtin 2-qubit reduction

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants