make QuadraticHamiltonian a subclass of PolynomialTensor #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsung
requested review from
stefan-woerner,
manoelmarques,
woodsp-ibm and
mrossinek
as code owners
Pull Request Test Coverage Report for Build 3298635436
💛 - Coveralls |
mrossinek
reviewed
Oct 17, 2022
mrossinek
reviewed
Oct 18, 2022
mrossinek
previously approved these changes
Oct 19, 2022
woodsp-ibm
reviewed
Oct 19, 2022
mrossinek
approved these changes
Oct 21, 2022
woodsp-ibm
approved these changes
Oct 21, 2022
Anthony-Gandon
pushed a commit
to Anthony-Gandon/qiskit-nature
that referenced
this pull request
May 25, 2023
…unity#890) * make QuadraticHamiltonian a subclass of PolynomialTensor * lint and mypy * improve repr * force keyword args * remove TolerancesMixin, pass validate through to PolynomialTensor * remove TODO * lint * fix bug in storage of antisymmetric tensor * mypy * revert chop * factor out validation into separate function * add note that rtol and atol are discarded after initialization * update type syntax and default tolerances Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #865
Details and comments