Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScipyMilpOptimizer #496

Merged
merged 20 commits into from
May 11, 2023
Merged

Add ScipyMilpOptimizer #496

merged 20 commits into from
May 11, 2023

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Apr 20, 2023

Summary

Adds ScipyMilpOptimizer based on Scipy's MILP solver.
Scipy introduced MILP solver since 1.9.0 (supports Python 3.8 or newer).

supersedes #447

This PR is a QAMP 22 fall project by @Dran-Z qiskit-advocate/qamp-fall-22#2

Details and comments

  • add more unit tests
  • update reno
  • update requirements.txt?

@t-imamichi t-imamichi added Changelog: New feature Include in the Added section of the changelog QAMP Qiskit Advocate Mentorship Program Commmunity PR PRs from contributors that are not 'members' of the Qiskit organization labels Apr 20, 2023
# Conflicts:
#	qiskit_optimization/algorithms/__init__.py
#	setup.py
@coveralls
Copy link

coveralls commented Apr 20, 2023

Pull Request Test Coverage Report for Build 4932946655

  • 78 of 78 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.312%

Totals Coverage Status
Change from base Build 4932878321: 0.1%
Covered Lines: 4443
Relevant Lines: 4813

💛 - Coveralls

@woodsp-ibm
Copy link
Member

Since we run coverage along with the other checks under 3.7 and this new code is not supported in that version this would explain the coverage drop. In Nature I had already bumped the checks to run under 3.8 - since we build/deploy docs under 3.8 and we build a documentation zip as part of the checks. I had bumped it since 3.7 is nearing EOL and I wanted to ensure that what I was seeing in the docs was indeed the same as what we published. This is a simple one line change and could be done in a separate PR to check things out - then once the branch is updated here we would get a better idea of the coverage of this new code.

@t-imamichi
Copy link
Collaborator Author

Thank you for your information. I will bump Python version for the check.

@t-imamichi t-imamichi added this to the 0.6.0 milestone Apr 26, 2023
@t-imamichi t-imamichi changed the title [WIP] Add ScipyMilpOptimizer Add ScipyMilpOptimizer May 1, 2023
@t-imamichi t-imamichi marked this pull request as ready for review May 1, 2023 09:23
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 100% test coverage of the ScipyMilpOptimzer - nice!

@t-imamichi t-imamichi requested a review from a-matsuo May 10, 2023 03:54
Copy link
Contributor

@a-matsuo a-matsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 9379ddf into qiskit-community:main May 11, 2023
@t-imamichi t-imamichi deleted the scipy-milp branch May 11, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Changelog: New feature Include in the Added section of the changelog Commmunity PR PRs from contributors that are not 'members' of the Qiskit organization QAMP Qiskit Advocate Mentorship Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants