Skip to content
This repository has been archived by the owner on Aug 15, 2020. It is now read-only.

Fix many issues #17

Closed
wants to merge 13 commits into from
Closed

Fix many issues #17

wants to merge 13 commits into from

Conversation

Bottersnike
Copy link
Contributor

@Bottersnike Bottersnike commented May 12, 2017

Fix #2, #7, #8, #14 and #18
Update to Discord.NET version 1.0.0-rc
Requires .NET framework version > 4.6 (I used 4.6.2). I have not yet tested using mono (because I don't have it) and thus if you're going to pull this, it might be worth putting it in a new branch.

I also apologize for the fact that it's all one large commit. It was many (separated by . in the commit message), but because I download ZIPed instead of forking, I had to fork it and then merge changes manually. Trust me, I tried to get my commits to come across as more than one, but I couldn't work out how.

…amework 4.6.2. Make the Y axis alphabetical not numerical. Fix bounds for grid co-ordinates. Add credits command.
@Bottersnike
Copy link
Contributor Author

For installation using mono:
First make sure that bot-token.txt is copied across.
cd into the root dir.
Run nuget restore . to download all of the packages.
Run xbuild to build.
Then cd into ./gamebot/bin/Debug and run the executable.

@Technochips
Copy link
Collaborator

well we use monodevelop to compile it

@Bottersnike
Copy link
Contributor Author

Okay I can confirm that it works with the latest version of mono.

@qixils
Copy link
Owner

qixils commented May 12, 2017

Issue 1: Can't successfully run/compile using the current hosting solution. (Mono 4.4.2, Ubuntu 17.04)
Details: Doesn't compile correctly with Mono 4.4.2's xbuild, even after doing a nuget restore .
image

Issue 2: When using a build successfully compiled by @Technochips using Mono 5.0.0, bot immediately crashed due to a missing winhttp.dll

Issue 3: @Technochips could not successfully run the bot using Mono 5.0.0 (latest mono). He got this when trying to run the bot:
Discord.Net.HttpException: The server responded with error 400: BadRequest
This is not much of a surprise as Discord.Net is known to not behave kindly with newer versions of mono.

@Bottersnike
Copy link
Contributor Author

Bottersnike commented May 12, 2017

Hmm. I'll have a look into it. I installed mono a few hours ago so it's definatly at the latest version for me. If you want, I can have a look to see what all the dlls etc. that it's using are and send over versions. When you installed all the nuget packages, were there any errors or warnings?

@Technochips
Copy link
Collaborator

at the same time, we are on linux, and that might be no good

@Bottersnike
Copy link
Contributor Author

Nahh. I'm fairly sure the point of mono is that it works on both. Are you using a user or bot account to run it on? If you're using a user account, check the email for that account as 400 is the error thrown for "new device".

@Technochips
Copy link
Collaborator

well geez, that's a lot of commits
might going to review it tomorrow, soon™

} //example: width is 4, it writes 1234
for (int i = 0; i < height; i++)
{
result += '\n'; //everytime it go to the next row in the game, creates a new line
result += "ABCDEFGHIJKLMNOPQRSTUVWXYZ"[i]; //it also enters the current height line
result += ":regional_indicator_" + "abcdefghijklmnopqrstuvwxyz"[i] + ":"; //it also enters the current height line
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this emoji might look invisible on mobile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. What's the best way to do the letter emojis then?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i don't know

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Do you know how your's is working?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(As in result += (i + 1) + "⃣";)

Copy link
Collaborator

@Technochips Technochips May 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it uses emoji 1️⃣ 2️⃣ 3️⃣ 4️⃣ 5️⃣ 6️⃣ 7️⃣ 8️⃣ 9️⃣, which is basically one number next to a keycap character

actually i'm not even sure if it works on mobile 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i looked up on emojipedia, numbers works, but letter doesn't work on apple

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :P

@qixils
Copy link
Owner

qixils commented May 25, 2017

Reportedly works on .NET core which doesn't support host OS yet (Ubuntu 17.04) - will properly test/merge when support eventually:tm: comes

@qixils
Copy link
Owner

qixils commented Jun 5, 2017

Dotnet Core for Ubuntu doesn't contain the required files to run net46 applications, which is what this application is based off of. Therefore, these changes can't currently be used in the current hosting environment.

And no, botter, don't go off and port this to python. i dont think mr @Technochips wants to deal with that

@qixils qixils closed this Jun 5, 2017
@Bottersnike
Copy link
Contributor Author

:D I won't. Don't worry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants