-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plantuml.jarArgs only works with absolute path #152
Comments
In fact, you can simply use:
the extension just passes your args to |
Thanks a lot for the quick reply :)
Hmm, that does not seem to work for me. When I trie, I get yet another FileNotFoundException indicating that the include files were searched in a path relative to the diagram location BUT, first things first: My original problem is with workspace configuration to execute When I execute plantuml.jar directly from workspace root:
with And this is how I would have expected the plugin to work for preview rendering. But that is obviously not the case. Hence the Here is my complete workspace config:
I believe it is pretty straight forward, plantuml diagrams is all I do in this workspace. |
BTW, I am working on macOS |
Yes, it's better to search include files in diagrams root (default, it is the workspace root), fixed path. |
Hi again, I appreciate the quick fix. However, I have experimented a bit plantuml.jar on the command line and wanted to give you the additional information. From my experiments it seems that plantuml.jar does not take
Now, as a negative check I tried the same command line without the
Imo, this is a bug in plantuml itself, so I already posted a Bug/Question for plantuml here. However, I'd also like to mention that an automatic 'plantuml.config' (by naming convention) search by the plugin looking in the following directories (in order):
might be worth considering. |
Since the setting is named as |
An alternative practice for your use case would be, If you want to include a config file for all diagrams, all projects: If you want to include config file different for each project: PS: I'll change the |
According to my test, the current A project:
with following workspace settings: {
"plantuml.diagramsRoot": "docs/src",
"plantuml.exportOutDir": "docs/out",
"plantuml.jarArgs": [
"-config",
"inc.iuml"
]
} Every file will include the PS: The extension set both the |
You can now test above setting with v2.9.6, please update. |
Unfortunately after installing the version containing these changes, I am no longer able to use the preview. I have the following layout:
Now I get the error message: Cannot include /Users/.../toplevelfolder/./../Intro.uml So the path it is looking up is now is wrong. Should be: /Users/.../toplevelfolder/subfolder1/../Intro.uml Running plantuml on the commandline still works as expected. Any idea how to solve this? |
@c-hoeger Now you can use |
The situation here is not that easy, unfortunately. There are some external automation scripts running on the same directory layout and when I break this path, they won't find the included files anymore. I really don't understand what is wrong in specifying the correct relative path to the included file(s). I am now using version 2.9.2 from your extension which works like it IMO should. |
Excellent, thanks! |
Hi again, my question here brought to light that there is a bug in the plantuml version used by the plugin (if you have not updated it yet). After replacing the integrated plantuml.jar with version 1.2018.11 No more absolute paths anywhere, only paths relative to Cheers |
Relative to |
This issue seems to have regressed in v2.15.1. I'm only referring to the Preview The following settings.json works:
but
results in
|
Please disregard the above - oddly enough, restarting VSCode and re-installing the plugin seemed to have solved the issue |
Hi,
many thanks for this great plugin.
However, I seem to be unable to get my project specific plantuml.config into the plugins preview renderer without using an absolute path.
The example says I should use
{ "settings": { "plantuml.jarArgs":[ "-config", "plantuml.config" ] } }
But where should the file then be located?
I tried
and some even more obscure paths. But all I get is a PathNotFoundException
Might this be related to this comment?
Ultimately, I think, it would be nice, if we could use
${workspaceFolder}
in workspace settings as well as the within plantuml config file itself to reference includes within the projects directory structure.The text was updated successfully, but these errors were encountered: