Don't say we've shut down cluster listener before having done so (has…

…hicorp#13679)
qk4l · Feb 4, 2022 · 263d358 · 263d358
1 parent d35a3b0
commit 263d358
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/changelog/13679.txt b/changelog/13679.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+core: Fix how we report the cluster listener is done, prevents `bind: address already in use` errors.
+```
diff --git a/vault/cluster/cluster.go b/vault/cluster/cluster.go
@@ -6,8 +6,6 @@ import (
 	"crypto/x509"
 	"errors"
 	"fmt"
-	"github.com/hashicorp/vault/sdk/helper/certutil"
-	"github.com/hashicorp/vault/sdk/helper/tlsutil"
 	"net"
 	"net/url"
 	"os"
@@ -16,7 +14,9 @@ import (
 	"time"
 
 	log "github.com/hashicorp/go-hclog"
+	"github.com/hashicorp/vault/sdk/helper/certutil"
 	"github.com/hashicorp/vault/sdk/helper/consts"
+	"github.com/hashicorp/vault/sdk/helper/tlsutil"
 	"golang.org/x/net/http2"
 )
 
@@ -279,9 +279,9 @@ func (cl *Listener) Run(ctx context.Context) error {
 		// Start our listening loop
 		go func(closeCh chan struct{}, tlsLn net.Listener) {
 			defer func() {
-				cl.shutdownWg.Done()
 				tlsLn.Close()
 				close(closeCh)
+				cl.shutdownWg.Done()
 			}()
 
 			// baseDelay is the initial delay after an Accept() error before attempting again