Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate reward block pending #368

Merged
merged 1 commit into from
May 25, 2019
Merged

Conversation

gythialy
Copy link
Contributor

Signed-off-by: Goren G yong.gu@qlink.mobi

Proposed changes in this pull request

Explain the changes in this pull request in order to help the project maintainers understand the overall impact of it.

Please put an x against the checkboxes.

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

Signed-off-by: Goren G <yong.gu@qlink.mobi>
@gythialy gythialy added this to the v1.2.0 milestone May 25, 2019
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #368 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #368      +/-   ##
=========================================
+ Coverage   44.59%   44.6%   +<.01%     
=========================================
  Files         171     171              
  Lines       17184   17186       +2     
=========================================
+ Hits         7664    7666       +2     
+ Misses       8328    8327       -1     
- Partials     1192    1193       +1
Impacted Files Coverage Δ
vm/contract/rewards.go 0% <0%> (ø) ⬆️
p2p/messageMonitor.go 45.94% <0%> (-0.61%) ⬇️
common/time.go 90.47% <0%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146ad60...d41e511. Read the comment docs.

@gythialy gythialy merged commit fbd13c0 into master May 25, 2019
@gythialy gythialy deleted the hotfix/generate-rewards branch May 25, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants