Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sync status rpc interface #377

Merged
merged 4 commits into from
May 29, 2019
Merged

feat: add sync status rpc interface #377

merged 4 commits into from
May 29, 2019

Conversation

wenchaopeng
Copy link
Contributor

Signed-off-by: wenchao 659672152@qq.com

Proposed changes in this pull request

Explain the changes in this pull request in order to help the project maintainers understand the overall impact of it.

Please put an x against the checkboxes.

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

Signed-off-by: wenchao <659672152@qq.com>
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #377 into master will decrease coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #377     +/-   ##
=========================================
- Coverage   44.73%   44.53%   -0.2%     
=========================================
  Files         168      168             
  Lines       17167    17209     +42     
=========================================
- Hits         7679     7664     -15     
- Misses       8297     8358     +61     
+ Partials     1191     1187      -4
Impacted Files Coverage Δ
rpc/api/net.go 0% <0%> (ø) ⬆️
p2p/sync.go 8.06% <0%> (-0.07%) ⬇️
p2p/messageMonitor.go 45.94% <0%> (-11.12%) ⬇️
p2p/types.go 58.62% <0%> (-6.9%) ⬇️
common/sync/hashmap/hashmap.go 95.81% <0%> (+0.93%) ⬆️
rpc/api/rewards.go 55.43% <0%> (+3.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d786c1d...a909ee9. Read the comment docs.

rpc/api/net.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gythialy gythialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure that syncingTime is thread safe

@gythialy gythialy added this to the v1.3.0 milestone May 28, 2019
Signed-off-by: wenchao <659672152@qq.com>
Signed-off-by: wenchao <659672152@qq.com>
Signed-off-by: wenchao <659672152@qq.com>
@gythialy gythialy merged commit 90a8e7d into master May 29, 2019
@wenchaopeng wenchaopeng deleted the feature/syncingrpc branch May 30, 2019 08:23
lc3091 pushed a commit that referenced this pull request Jun 4, 2019
 add sync status rpc interface

Signed-off-by: wenchao <659672152@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants