Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null pointer bug with rpc interface #405

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Conversation

wenchaopeng
Copy link
Contributor

Signed-off-by: wenchao 659672152@qq.com

Proposed changes in this pull request

Explain the changes in this pull request in order to help the project maintainers understand the overall impact of it.

Please put an x against the checkboxes.

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

Signed-off-by: wenchao <659672152@qq.com>
@wenchaopeng wenchaopeng added this to the v1.3.0 milestone Jun 14, 2019
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #405 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage    44.1%   44.11%   +<.01%     
==========================================
  Files         168      168              
  Lines       17221    17313      +92     
==========================================
+ Hits         7596     7637      +41     
- Misses       8422     8458      +36     
- Partials     1203     1218      +15
Impacted Files Coverage Δ
rpc/api/ledger.go 0% <0%> (ø) ⬆️
rpc/api/rewards.go 47.61% <0%> (-5.02%) ⬇️
rpc/api/mintage.go 0% <0%> (ø) ⬆️
rpc/api/nep5_pledge.go 0% <0%> (ø) ⬆️
common/sync/hashmap/list.go 78.65% <0%> (-2.25%) ⬇️
p2p/sync.go 7.01% <0%> (-1.05%) ⬇️
rpc/utils.go 89% <0%> (-1%) ⬇️
common/sync/hashmap/hashmap.go 94.88% <0%> (-0.94%) ⬇️
p2p/streamManager.go 78.23% <0%> (+2.17%) ⬆️
common/time.go 90.47% <0%> (+4.76%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701cfd2...e5fb7b7. Read the comment docs.

Copy link
Contributor

@gythialy gythialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if private key is nil, will not sign the block and it should be OK

rpc/api/ledger.go Outdated Show resolved Hide resolved
Signed-off-by: wenchao <659672152@qq.com>
@gythialy gythialy merged commit d6d0818 into master Jun 14, 2019
@wenchaopeng wenchaopeng deleted the hotfix/blockCheck branch June 14, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ledger process block may case painc when call map "checkBlockFns"
2 participants