[QOL-9055] fix parameter name for 'follow' Pylons routing #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
requested review from
duttonw,
devonpis,
kundupz,
asifaminb,
chris-randall-qol and
RossWebsterWork
- Add Python snippet to more robustly retrieve IDs from test JSON - Use CKAN 2.9 by default - Robustly detect appropriate test requirement files for each plugin
duttonw
approved these changes
Jul 28, 2022
| @@ -11,7 +12,7 @@ ENV CKAN_INI=/app/ckan/default/production.ini | |||
| WORKDIR "${APP_DIR}" | |||
|
|
|||
| ENV DOCKERIZE_VERSION v0.6.1 | |||
| RUN apk add --no-cache curl build-base git libxml2-dev libxslt-dev postgresql postgresql-client postgresql-dev \ | |||
| RUN apk add --no-cache curl build-base git libffi-dev libxml2-dev libxslt-dev postgresql postgresql-client postgresql-dev \ | |||
There was a problem hiding this comment.
interesting https://sourceware.org/libffi/
There was a problem hiding this comment.
It's not really needed for this particular extension, it's more for ckanext-harvest, but we may as well make our containers as consistent as possible.
| for filename in requirements-$PYTHON_VERSION.txt requirements.txt pip-requirements.txt; do | ||
| if [ -f "$PROJECT_DIR/$filename" ]; then | ||
| pip install -r "$PROJECT_DIR/$filename" | ||
| return 0 |
There was a problem hiding this comment.
could you add comment, like
run first file found and break loop.
| @@ -37,8 +37,8 @@ def comment(self, id): | |||
| def delete_comment(self, datarequest_id, comment_id): | |||
There was a problem hiding this comment.
so not changing delete_comment to id also?
There was a problem hiding this comment.
No. This one uses the names consistently, plus it has two separate IDs that it needs to distinguish.
- use a single function that automatically handles suffixes and alternatives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.