-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QOL-9055] fix parameter name for 'follow' Pylons routing #73
Conversation
- Add Python snippet to more robustly retrieve IDs from test JSON - Use CKAN 2.9 by default - Robustly detect appropriate test requirement files for each plugin
@@ -11,7 +12,7 @@ ENV CKAN_INI=/app/ckan/default/production.ini | |||
WORKDIR "${APP_DIR}" | |||
|
|||
ENV DOCKERIZE_VERSION v0.6.1 | |||
RUN apk add --no-cache curl build-base git libxml2-dev libxslt-dev postgresql postgresql-client postgresql-dev \ | |||
RUN apk add --no-cache curl build-base git libffi-dev libxml2-dev libxslt-dev postgresql postgresql-client postgresql-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting https://sourceware.org/libffi/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really needed for this particular extension, it's more for ckanext-harvest, but we may as well make our containers as consistent as possible.
for filename in requirements-$PYTHON_VERSION.txt requirements.txt pip-requirements.txt; do | ||
if [ -f "$PROJECT_DIR/$filename" ]; then | ||
pip install -r "$PROJECT_DIR/$filename" | ||
return 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add comment, like
run first file found and break loop.
@@ -37,8 +37,8 @@ def comment(self, id): | |||
def delete_comment(self, datarequest_id, comment_id): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so not changing delete_comment to id also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. This one uses the names consistently, plus it has two separate IDs that it needs to distinguish.
- use a single function that automatically handles suffixes and alternatives
No description provided.