Adding possibility to use external chrome

qlik-oss · Nov 7, 2018 · 1a11803 · 1a11803
1 parent 57ad575
commit 1a11803
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/commands/puppeteer/src/index.js b/commands/puppeteer/src/index.js
@@ -38,7 +38,12 @@ class PuppetRunner extends Runner {
       this.argv.mocha.enableTimeouts = false;
     }
 
-    this.browser = await this.puppeteer.launch(this.argv.chrome);
+    if (this.argv.browserWSEndpoint){
+      this.browser = await this.puppeteer.connect({ browserWSEndpoint: this.argv.browserWSEndpoint });
+    } else {
+      this.browser = await this.puppeteer.launch(this.argv.chrome);
+    }
+
     global.browser = this.browser;
     const pages = await this.browser.pages();
     if (pages.length) {

diff --git a/commands/puppeteer/src/options.js b/commands/puppeteer/src/options.js
@@ -10,6 +10,11 @@ module.exports = {
     default: ['test/**/*.spec.js'],
     type: 'array',
   },
+  browserWSEndpoint: {
+    description: 'Connect to external chrome WS endpoint (`ws://localhost:3000`)',
+    type: 'string',
+    default: null,
+  },
   'mocha.enableTimeouts': {
     description: 'Enable timeouts',
     default: false,