Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Commit

Permalink
Fixing review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Helene Rigner committed Jan 22, 2019
1 parent f661c7e commit 2df0f86
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 15 deletions.
14 changes: 7 additions & 7 deletions src/components/guide-steps.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const steps = [
<div>
<h2>Welcome to catwalk!</h2>
<p>
Catwalk lets you explore your data model to gain
catwalk lets you explore your data model to gain
insights about fields, associations and how interactions
with the data impacts the model.
</p>
Expand All @@ -23,11 +23,13 @@ const steps = [
<div>
<h2>Welcome to catwalk!</h2>
<p>The URL to catwalk is</p>
{window.location.href}
<span className="breakword">
{window.location.href}
</span>
<p>
where
{' '}
<i>engine_url</i>
<code>engine_url</code>
{' '}
points to the app containing the data model. Change this to explore another data model.
</p>
Expand Down Expand Up @@ -113,12 +115,10 @@ const steps = [
selections. Selections might be helpful when trying to figure out the data model, and to find errors in the data model.
</p>
<p>
Go ahead and make a selection!
Go ahead, click the field and make a selection!
</p>
</div>
),
disableOverlayClose: true,
hideFooter: true,
spotlightClicks: true,
placement: 'right',
target: '.vertcell.keycell',
Expand Down Expand Up @@ -223,7 +223,7 @@ const steps = [
<p>
To restart the guide, right click and select
{' '}
<i>Start Guide</i>
<code>Start Guide</code>
.
</p>
</div>
Expand Down
9 changes: 1 addition & 8 deletions src/components/guide.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,7 @@ const Guide = forwardRef((props, ref) => {
setRunGuide(false);
setRunGuide(true);
}
if (parentElemName === 'ReactVirtualized__Table__rowColumn' || parentElemName === 'ReactVirtualized__Grid__innerScrollContainer') {
// a click in the filterbox area.
setTimeout(() => {
if (document.getElementsByClassName('selection-field').length > 0) {
setStepIndex(steps.findIndex(s => s.step === 'selections'));
}
}, 600);
} else if (parentElemName === 'add-button') {
if (parentElemName === 'add-button') {
// a click on the big hypercube builder button.
setStep('selectEntity');
} else if (parentElemName === 'expression' || parentElemName === 'expression-list') {
Expand Down
4 changes: 4 additions & 0 deletions src/components/guide.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,7 @@
.default {
border: solid 2px #f29600;
}

.breakword {
overflow-wrap: break-word;
}

0 comments on commit 2df0f86

Please sign in to comment.