This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Fixing forceUpdate not working in latest versions of React #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for catwalk-qlikcore ready! Built with commit 992501a |
axelssonHakan
approved these changes
Feb 20, 2019
peol
reviewed
Feb 20, 2019
| @@ -165,7 +165,9 @@ export default function HypercubeTable({ | |||
| const hypercubeProps = createProperties(dimensions, measures); | |||
| const model = useModel(app, hypercubeProps); | |||
| const layout = useLayout(model); | |||
|
|
|||
| if (!model) { | |||
| return null; | |||
There was a problem hiding this comment.
Do we want a "loading" thingie here instead of null?
src/components/cubes.jsx
Outdated
| @@ -39,7 +39,7 @@ export function Cubes({ app, closeOnClickOutside }) { | |||
|
|
|||
| function openColumnChooser() { | |||
| addOpen.current = true; | |||
| forceUpdate(); | |||
| forceUpdate(Date.now()); | |||
There was a problem hiding this comment.
I think it would be nicer with a const forceUpdate = useForce(); hook, that did the Date.now() magic behind the scenes, so you'd still just do forceUpdate(). That way we can keep the logic in one place and change it easily in the future if needed.
There was a problem hiding this comment.
Added a useForce hook using a bool instead of Date.now().
peol
approved these changes
Feb 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #187