This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Add support for variables #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wennmo
reviewed
Jun 3, 2019
cmd/variable.go
Outdated
| Args: cobra.ExactArgs(1), | ||
| Short: "Evaluate the layout of an generic variable", | ||
| Long: "Evaluate the layout of an generic variable", | ||
| Example: "corectl variable layout DIMENSION-ID", |
| @@ -60,7 +60,7 @@ var listDimensionsCmd = &cobra.Command{ | |||
| Run: func(ccmd *cobra.Command, args []string) { | |||
| state := internal.PrepareEngineState(rootCtx, headers, false) | |||
| items := internal.ListDimensions(state.Ctx, state.Doc) | |||
| printer.PrintNamedItemsList(items, viper.GetBool("bash")) | |||
| printer.PrintNamedItemsList(items, viper.GetBool("bash"), false) | |||
There was a problem hiding this comment.
Do we only want to print the title for variables?
There was a problem hiding this comment.
With the bash-flag yes, since we can only retrieve variables by name. Normally the print for bash completion only prints IDs so it had to be modified to support this case.
gabbaxx
approved these changes
Jun 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains commands to manage variables. It seems that there are two types of variables: Variables and GenericVariables. As we want to use GenericVariables - I am assuming - we have to use the method GetVariableByName as it is the only getter that returns said type.
Tests (golden even) pass, don't seem to have the same problems as bookmarks.
Closes #298