Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont emit message if resolver undefined #968

Merged
merged 1 commit into from Mar 10, 2023

Conversation

simonmcmillan
Copy link
Contributor

With our implementation of Enigma we hit a snag where the resolver can be undefined.

This fix ensures that if the resolver is undefined Enigma wont crash.

@qlikossbuild
Copy link

Hi, and thanks for contributing!

Note: If you are part of Qlik R&D, you can apply to the open-source team in our internal GitHub organization, and ignore the rest of these instructions.

Before we can handle your pull request we need you to sign our contributor license agreement.
This is a one-time process and enables you to contribute without hassle to any of the qlik-oss repositories in the future.

And it only takes a few minutes! Here are some useful links to get you started:

Having troubles? Feel free to reach out to us either here or on Slack!

Note: Once the CLA is sorted, you should rebase/touch this pull request to trigger an update of this CLA status.

@aihazm
Copy link
Member

aihazm commented Feb 28, 2023

Hi @simonmcmillan, (apologies for the delay...)
could you please rebase on master, we are trying to figure out why the CI builds are failing

@aihazm
Copy link
Member

aihazm commented Mar 10, 2023

Hi @simonmcmillan
Even though red, we will merge the PR - the build fails due to cross-forks secrets sharing (we are not able to allow sharing secrets across forks due to obvious security reasons) - thank you for the patience

@aihazm aihazm merged commit 62ef71a into qlik-oss:master Mar 10, 2023
@simonmcmillan
Copy link
Contributor Author

Awesome thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants