Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for engine ARGB colors #1033

Merged
merged 4 commits into from Dec 20, 2022
Merged

chore: add support for engine ARGB colors #1033

merged 4 commits into from Dec 20, 2022

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Dec 16, 2022

Motivation

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@T-Wizard
Copy link
Collaborator

why?
It looks like the color is an expression that would work is engine evaluaded it but it was not evaluated by engine.

@Caele
Copy link
Collaborator Author

Caele commented Dec 18, 2022

why? It looks like the color is an expression that would work is engine evaluaded it but it was not evaluated by engine.

Given the expression =argb(100,200,Sum(sales),255) engine will calculate a dual:
qNum: 29875577 // numeric rgba representation
qText: "ARGB(100,200,123,255)"
So when we are using a qStringExpression we only get the qText back. Most other applications of color by expression is on the hyperCube, and then we get both qNum and qText and tend to use qNum.

@Caele Caele merged commit fb7f23a into master Dec 20, 2022
@Caele Caele deleted the tsm/support-ARGB branch December 20, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants