Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hide search button on edit mode #1099

Closed
wants to merge 2 commits into from
Closed

feat: hide search button on edit mode #1099

wants to merge 2 commits into from

Conversation

cosmar26
Copy link
Contributor

@cosmar26 cosmar26 commented Mar 2, 2023 •
edited

Motivation

Like for the existing filter pane, hide the search button when on edit mode.

Screenshot 2023-03-02 at 16 28 08

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@cosmar26
Copy link
Contributor Author

Closing this as it was fixed by #1129

@cosmar26 cosmar26 closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caele Caele Caele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cosmar26 @Caele