fix: show drilldown icon for drilldown dimension #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanlahti
reviewed
Mar 12, 2023
johanlahti
reviewed
Mar 12, 2023
johanlahti
approved these changes
Mar 12, 2023
6 tasks
Caele
pushed a commit
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix qlik-oss/sn-list-objects#66.
It shows a drill-down icon to the left of a dimension title.
Since icons have padding left and padding right 7px so when there are one ore more icons there are too much space between the first left icon and the left border and also too much space between icons. This PR also adjusts the padding between icons and between the title and the left border based on if there are any icons or not.
Search icon shown in analysis mode
Search icon hidden in edit mode
Search icon hidden in analysis mode when a dimension is locked; lock icon is enabled
Search icon hidden in edit mode when a dimension is locked; lock icon is disabled
