Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update style for higlighted text during search #1179

Merged
merged 1 commit into from
Mar 23, 2023
Merged

fix: update style for higlighted text during search #1179

merged 1 commit into from
Mar 23, 2023

Conversation

quanho
Copy link
Collaborator

@quanho quanho commented Mar 23, 2023

Motivation

To fix qlik-oss/sn-list-objects#208.
Before:
Screenshot 2023-03-23 at 13 47 26

After:
Screenshot 2023-03-23 at 13 54 33

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@quanho quanho merged commit e7b1cc7 into master Mar 23, 2023
@quanho quanho deleted the hva/sn-filter-pane-208 branch March 23, 2023 13:10
@quanho quanho mentioned this pull request Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanlahti johanlahti johanlahti approved these changes

@T-Wizard T-Wizard Awaiting requested review from T-Wizard

@DanielS-Qlik DanielS-Qlik Awaiting requested review from DanielS-Qlik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search result looks weird when the checkbox mode is on
2 participants
@quanho @johanlahti