This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
fix: add data to snapshot #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxxmaxx
reviewed
Feb 19, 2020
niekvanstaveren
approved these changes
Feb 19, 2020
Caele
commented
Feb 19, 2020
| @@ -155,7 +154,7 @@ export default function supernova(env) { | |||
| * - render [allNodes, positioning, styling, rect] | |||
| */ | |||
|
|
|||
| usePromise(() => { | |||
| const [dataTree] = usePromise(() => { | |||
There was a problem hiding this comment.
This was likely not needed, but removes a state for us.
Caele
commented
Feb 19, 2020
| @@ -181,11 +186,11 @@ export function createNodes(matrix, attributeIndecies, status, navigationMode, t | |||
| const parentNode = nodeMap[node.parentId]; | |||
| node.parent = parentNode; | |||
| if (parentNode) { | |||
| parentNode.children.length > 100 | |||
| parentNode.children.length > 98 | |||
There was a problem hiding this comment.
Changed this to 98, so that the max number of children becomes 99, which fits in the +/- box.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshot now only stores the data it needs, which is the nodes you see, plus their children (to get the numbers right, bit of a shortcut).