Merge pull request FRRouting#14443 from opensourcerouting/coverity-re…

…dux-20230919 lib: constrain hash table "tabshift" both ways
qlyoung · Sep 20, 2023 · 7a80a23 · 7a80a23
2 parents 2341a65 + e7737c8
commit 7a80a23
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/typesafe.h b/lib/typesafe.h
@@ -795,13 +795,16 @@ struct thash_head {
 	uint8_t minshift, maxshift;
 };
 
-#define _HASH_SIZE(tabshift) \
-	((1U << (tabshift)) >> 1)
+#define _HASH_SIZE(tabshift)                                                   \
+	({                                                                     \
+		assume((tabshift) <= 31);                                      \
+		(1U << (tabshift)) >> 1;                                       \
+	})
 #define HASH_SIZE(head) \
 	_HASH_SIZE((head).tabshift)
 #define _HASH_KEY(tabshift, val)                                               \
 	({                                                                     \
-		assume((tabshift) >= 2 && (tabshift) <= 33);                   \
+		assume((tabshift) >= 2 && (tabshift) <= 31);                   \
 		(val) >> (33 - (tabshift));                                    \
 	})
 #define HASH_KEY(head, val) \