Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keymap for keebio/nyquist #11734

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Update keymap for keebio/nyquist #11734

merged 1 commit into from
Feb 7, 2021

Conversation

GeorgePetri
Copy link
Contributor

@GeorgePetri GeorgePetri commented Jan 30, 2021 •
edited

Description

#7754 caused a rgb's not to work on the right side, I had to do a #undef RGBLED_SPLIT to fix it.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, rgbled_split should work here. Though, that depends on how they're wired up.

But looks good, otherwise.

@drashna drashna requested a review from a team February 5, 2021 04:35
@GeorgePetri
Copy link
Contributor Author

It's an older build. I think I wired it the older way.

@drashna drashna merged commit 13c562e into qmk:master Feb 7, 2021
@GeorgePetri GeorgePetri deleted the update-nyquist branch February 7, 2021 18:12
jordanlewis added a commit to jordanlewis/qmk_firmware that referenced this pull request Feb 8, 2021
@jordanlewis
Merge remote-tracking branch 'upstream/master' into master
6b70057 
* upstream/master: (723 commits)
  [Keyboard] Add The Stick keyboard (qmk#11745)
  [Docs] Update isp_flashing_guide.md (qmk#11777)
  [Keymap] Update keymap for keebio/nyquist (qmk#11734)
  [Keymap] Shadyproject/bfo9000 (qmk#11753)
  [Keymap] Update community ortholinear 4x12 keymap: junonum (qmk#11757)
  [Keyboard] Add my keymap for Mark65 (qmk#11717)
  [Keyboard] Add nknl7jp keyboard (qmk#11591)
  [Keyboard] Add nknl7en keyboard (qmk#11590)
  [Keyboard] Add ergoarrows keyboard (qmk#11592)
  [Keyboard] Add Hi-Tek AIM-65 keyboard (qmk#11623)
  [Keyboard] Add earth_rover keyboard (qmk#11405)
  [Keyboard] Whale 75 (qmk#11486)
  [Keyboard] VIA fix firmware sizes (qmk#11770)
  Fixed pin assignment on KBD8X Hotswap by Lucid (qmk#11807)
  Manual formatting fix for serial_uart.c (qmk#11806)
  [CI] Auto Formatting - Swap from direct commit to PR (qmk#11229)
  [Keyboard] add info.json of Sparrow62 (qmk#11740)
  Serial refactor (qmk#11521)
  update lck75 json file (qmk#11798)
  Manually run formatting job (qmk#11797)
  ...
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Feb 10, 2021
@GeorgePetri @sowbug
[Keymap] Update keymap for keebio/nyquist (qmk#11734)
a469a58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GeorgePetri @drashna @fauxpark