Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keebio RGB wiring update #7754

Merged
merged 8 commits into from Aug 12, 2020
Merged

Keebio RGB wiring update #7754

merged 8 commits into from Aug 12, 2020

Conversation

nooges
Copy link
Member

@nooges nooges commented Jan 1, 2020 •
edited

Description

Change configuration for Keebio split boards to use the same RGB strip wiring for each half, which provides the following improvements:

  1. Easier wiring due to one fewer wire needed (the wire between left DOut to extra data pin) and the fact that wiring is the same for both halves.
  2. RGB LEDs can be controlled by each half now instead of just master half.
  3. Extra data line is freed up to allow for I2C usage instead of serial.

Keebio docs have also been updated already to reflect new wiring setup.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label Jan 2, 2020
@zvecr
Copy link
Member

zvecr commented Jan 2, 2020

Tagging as "breaking change" till we work out what the impact is.

@zvecr zvecr added the keyboard label Jan 2, 2020
@SethBarberee
Copy link
Contributor

Looks like my keymap for the iris gives an error since I define RGBLED_SPLIT. You've got my permission to modify the keymap if you need to, @nooges

@nooges
Copy link
Member Author

nooges commented Jan 3, 2020

@SethBarberee I'll test out adding a check to see if RGBLED_SPLIT is already defined by the user to get rid of the impact on keymaps.

@bcat
Copy link
Contributor

bcat commented Jan 4, 2020

My Quefrency keymap has the same problem. Feel free to toss an #undef RGBLED_SPLIT into said keymap to fix this.

@stale stale bot removed the awaiting changes label Jan 5, 2020
@nooges nooges added the on hold label Jan 5, 2020
@SethBarberee SethBarberee mentioned this pull request Jan 10, 2020
Merged
13 tasks
@nooges
Copy link
Member Author

nooges commented Jan 29, 2020

Note to self: add #undef RGBLED_SPLIT to user keymaps as needed

@bcat bcat mentioned this pull request Feb 11, 2020
Merged
13 tasks
@nooges nooges changed the base branch from master to develop August 11, 2020 20:06
@nooges nooges removed the on hold label Aug 11, 2020
@nooges
Copy link
Member Author

nooges commented Aug 11, 2020

Rebased PR on top of develop and checked that the affected users using their own #define RGBLED_SPLIT have #undef.

@tzarc tzarc requested a review from a team August 12, 2020 01:59
noroadsleft
noroadsleft approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit d98e044 into qmk:develop Aug 12, 2020
@noroadsleft
Copy link
Member

Thanks!

@nooges nooges deleted the keebio-rgb-update branch August 12, 2020 19:11
noroadsleft pushed a commit that referenced this pull request Aug 27, 2020
@nooges @noroadsleft
Keebio RGB wiring update (#7754)
f2b5274 
* Change RGB wiring for Levinson

* Update RGB wiring for Iris

* Update RGB wiring for Nyquist

* Update RGB wiring for Quefrency

* Update RGB wiring for Viterbi

* Update RGB wiring for Fourier

* Update RGB wiring for BFO

* Handle redefinition of RGBLED_SPLIT
noroadsleft pushed a commit that referenced this pull request Aug 29, 2020
@nooges @noroadsleft
Keebio RGB wiring update (#7754)
ea43bc8 
* Change RGB wiring for Levinson

* Update RGB wiring for Iris

* Update RGB wiring for Nyquist

* Update RGB wiring for Quefrency

* Update RGB wiring for Viterbi

* Update RGB wiring for Fourier

* Update RGB wiring for BFO

* Handle redefinition of RGBLED_SPLIT
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@nooges @nicocesar
Keebio RGB wiring update (qmk#7754)
31841be 
* Change RGB wiring for Levinson

* Update RGB wiring for Iris

* Update RGB wiring for Nyquist

* Update RGB wiring for Quefrency

* Update RGB wiring for Viterbi

* Update RGB wiring for Fourier

* Update RGB wiring for BFO

* Handle redefinition of RGBLED_SPLIT
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@nooges @noroadsleft
Keebio RGB wiring update (qmk#7754)
65a7168 
* Change RGB wiring for Levinson

* Update RGB wiring for Iris

* Update RGB wiring for Nyquist

* Update RGB wiring for Quefrency

* Update RGB wiring for Viterbi

* Update RGB wiring for Fourier

* Update RGB wiring for BFO

* Handle redefinition of RGBLED_SPLIT
@GeorgePetri GeorgePetri mentioned this pull request Jan 30, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
breaking_change Changes that need to wait for a version increment keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nooges @zvecr @SethBarberee @bcat @noroadsleft @tzarc