Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove kc layout from levinson jyh keymap #12301

Merged
merged 1 commit into from
Apr 3, 2021
Merged

remove kc layout from levinson jyh keymap #12301

merged 1 commit into from
Apr 3, 2021

Conversation

yamad
Copy link
Contributor

@yamad yamad commented Mar 20, 2021 •
edited

Description

Converts kc macros to normal layout macros in the levinson:jyh keymap, as per deprecation of the KC macros in #12160.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei mtei requested a review from a team March 30, 2021 09:28
@drashna drashna merged commit caca894 into qmk:master Apr 3, 2021
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@yamad @makenova
[Keymap] remove kc layout from levinson jyh keymap (qmk#12301)
24c62e3 
Co-authored-by: Jason Yamada-Hanff <jyamada-hanff@chromologic.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@yamad @HokieGeek
[Keymap] remove kc layout from levinson jyh keymap (qmk#12301)
138cbb3 
Co-authored-by: Jason Yamada-Hanff <jyamada-hanff@chromologic.com>
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@yamad @mrtnee
[Keymap] remove kc layout from levinson jyh keymap (qmk#12301)
0700d75 
Co-authored-by: Jason Yamada-Hanff <jyamada-hanff@chromologic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtei mtei mtei approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yamad @mtei @drashna @fauxpark