Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WSL specific logic for avrdude device detection #12392

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Add WSL specific logic for avrdude device detection #12392

merged 1 commit into from
Apr 3, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 26, 2021 •
edited
Loading

Description

None of the other flashers currently spit out any WSL specific errors, so ive not kept that logic for avrdude.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Mar 26, 2021
@zvecr zvecr mentioned this pull request Mar 26, 2021
Open
9 tasks
@zvecr zvecr marked this pull request as ready for review March 26, 2021 23:59
@drashna drashna requested a review from a team April 3, 2021 04:23
@zvecr zvecr merged commit 60e1910 into qmk:master Apr 3, 2021
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@zvecr @makenova
Add WSL specific logic for avrdude device detection (qmk#12392)
8549d81
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@zvecr @HokieGeek
Add WSL specific logic for avrdude device detection (qmk#12392)
ec623b8
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Add WSL specific logic for avrdude device detection (qmk#12392)
2f2d36a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @drashna