Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover old implementations of the lily58 split code. #12442

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Mar 31, 2021

Description

Take 2 of migrating Lily58 to split common. Seems there were leftover files from #6260 that aren't required.

As yet untested.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team March 31, 2021 05:47
@fauxpark fauxpark requested a review from a team March 31, 2021 05:49
@tzarc
Copy link
Member Author

tzarc commented Mar 31, 2021

Confirmed functional by @keyboard-magpie (bomtarnes) on Discord.

@tzarc tzarc changed the base branch from develop to master March 31, 2021 13:07
@tzarc tzarc merged commit c5ddada into qmk:master Mar 31, 2021
@tzarc tzarc deleted the lily58-cleanup branch March 31, 2021 13:09
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
dwursteisen added a commit to dwursteisen/qmk_firmware that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants