Added via layout to GMMK Pro #12555
Closed
Added via layout to GMMK Pro #12555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
Realized this file is supposed to go into the via repo.
|
Absolutely wild timing, it looks like this was submitted just after mine for the same things! I didn't do the changes to info.json though (adding the labels) |
drashna
reviewed
Apr 19, 2021
| @@ -7,104 +7,104 @@ | |||
| "layouts": { | |||
| "LAYOUT": { | |||
| "layout": [ | |||
| {"x":0, "y":0}, | |||
| {"label": "k13", "x":0, "y":0}, | |||
|
Also, (for ease) duplicate of #12554 |
|
Since #12554 is merged in, I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a VIA layout to the Glorious GMMK Pro. Layout and VIA configurator have been fully tested, I also needed to make a change to pro.h because the default layout had the FN and right alt keys swapped. info.json was also updated to include labels for all keys.
Types of Changes
Issues Fixed or Closed by This PR
Checklist