GMMK Pro: Fixed Bootmagic Lite support; added personal keymap and VIA support #12554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sonal keymap to reflect fixed layout.
|
I realized in one of my previous commits I said I added 1000hz polling, but forgot to mention in a later commit that I removed this. |
WholesomeDucky
changed the title
github-actions
bot
added
the
via
|
Additional commits added for VIA support. This is tested to the absolute best of my ability and I am submitting a PR for the via repo to have my JSON for the board. |
WholesomeDucky
changed the title
drashna
approved these changes
Apr 19, 2021
I mean, looks good to me! |
Sweet, I'll PR to VIA in about an hour |
14 tasks
6 tasks
noroadsleft
requested changes
Apr 27, 2021
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
noroadsleft
approved these changes
Apr 27, 2021
noroadsleft
changed the title
|
Thanks! |
rizo
pushed a commit
to rizo/qmk_firmware
that referenced
this pull request
May 10, 2021
…mk#12554) * Added WholesomeDucky keymap for GMMK Pro * Finalized keymap & added 1000hz polling for GMMK Pro * Corrected for RAlt and Fn being swapped * Fixed RAlt and Fn being swapped in the layout definition. Updated personal keymap to reflect fixed layout. * Removed an old comment from personal keymap for GMMK Pro * added VIA support * Defined bootmagic row and column for GMMK Pro Esc key * Update keyboards/gmmk/pro/config.h * Update keyboards/gmmk/pro/keymaps/via/keymap.c * Update keyboards/gmmk/pro/keymaps/via/keymap.c
toddyamakawa
pushed a commit
to toddyamakawa/qmk_firmware
that referenced
this pull request
May 19, 2021
…mk#12554) * Added WholesomeDucky keymap for GMMK Pro * Finalized keymap & added 1000hz polling for GMMK Pro * Corrected for RAlt and Fn being swapped * Fixed RAlt and Fn being swapped in the layout definition. Updated personal keymap to reflect fixed layout. * Removed an old comment from personal keymap for GMMK Pro * added VIA support * Defined bootmagic row and column for GMMK Pro Esc key * Update keyboards/gmmk/pro/config.h * Update keyboards/gmmk/pro/keymaps/via/keymap.c * Update keyboards/gmmk/pro/keymaps/via/keymap.c
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
…mk#12554) * Added WholesomeDucky keymap for GMMK Pro * Finalized keymap & added 1000hz polling for GMMK Pro * Corrected for RAlt and Fn being swapped * Fixed RAlt and Fn being swapped in the layout definition. Updated personal keymap to reflect fixed layout. * Removed an old comment from personal keymap for GMMK Pro * added VIA support * Defined bootmagic row and column for GMMK Pro Esc key * Update keyboards/gmmk/pro/config.h * Update keyboards/gmmk/pro/keymaps/via/keymap.c * Update keyboards/gmmk/pro/keymaps/via/keymap.c
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inside pro.h, the keys that are normally "RAlt" and "Fn" were swapped, causing confusion in making keymaps, since Fn needed to be left of RAlt in the keymap when the physical key is to the right.
My personal keymap is also included, which I adjusted alongside my fix for these two keys being swapped.
Default keymap is already correct and does not need to be changed for this (although RGUI is used instead of Fn. Maybe good use of Fn couldn't be made here?)
Added VIA support. JSON made by me is being submitted to VIA repo.
config.h has been changed to have bootmagic row/column defined for this board to use Esc instead of LShift for Bootmagic.
Firmwares in question have been compiled and flashed to my board with my keymap & tested.
First PR, always open to feedback on how to do things better.
Types of Changes
Issues Fixed or Closed by This PR
Checklist